Skip to content

Add ability to pass the CaloDetDescrManager to the CaloDepthTool.

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:Calo_depth_tool_pipe_in_CaloDetDescr_Part_I into master

This is in order to progress with ATLASRECTS-5012 items in https://docs.google.com/spreadsheets/d/1buz35Fn8_jzMwGxqzP_NAGML65ppgE0Fc83u1pPMVD0/edit#gid=0

  • Add ability to pass the CaloDetDescrManager to the CaloDepthTool (clean up a bit the code).
  • Pipe it from CaloSurfaceBuilder to CaloDepthTool (also rm unused methods tidy code).
  • Pipe it from CaloExtensionTool to CaloSurfaceBuilder (see if it works)
  • Pipe it from egammaAlgs/Tools to CaloExtensionTool (see it if it wors)

In next step if we this works we could rm the CaloDepthTool::caloMgr() pass from clients migrated to conditions handles etc for the CaloDetDescrManager retrieval (ping @tsulaia ) .

This will leave the issue to CaloSurfaceBuilder, this prb is one MR later (move things to LarVolumeBuilder/Cond).

the idea is that by passing by to the tools (rather retrieving from a tool deep down some hierarchy), we can factorise the retrieval and have an easier time finalizing ATLASRECTS-5012

Plan :

  • Next MR will remove the retrievals from CaloDepth, clients will have to pass it
  • Then one after will try to handle the CaloSurfaceBuilder same way
Edited by Christos Anastopoulos

Merge request reports