Adding monitoring metrics for PFlow track extrapolation (and related tools) (ATR-22226)

This merge request is part of my qualification task specified in this (https://its.cern.ch/jira/browse/ATR-22226) JIRA ticket. It adds some monitoring metrics to PFAlgorithm, PFCellLevelSubtraction, PFTrackClusterMatching, PFTrackSelector and TrackExtrapolator tool. These metrics are mostly related to timing, but there are added also performance-related metrics related to e.g. cluster matching efficiency which can be affected by the change in extrapolation performance. The reason for adding these metrics is to be able to quantify performance of track extrapolation step in PFlow algorithm.

requested review from @cantel

added 1 commit

• f4598b2f - Removing unnecessary PFCellLevelSubtraction monitoring metric.

Compare with previous version

added 2 commits

• 727097e4 - Removing duplicate metric - number of selected tracks
• 5f80973e - Adding back accidentally removed line in the second last commit.

Compare with previous version

added 1 commit

• 1891d3cb - Adding label to the PFAlgorithm histogram - clusters

Compare with previous version

marked this merge request as ready

There were multiple CI triggers for this MR and commit. The system ignored duplicates. However the GitLab pipelines status may be shown incorrectly.

This merge request affects 1 package:

• Reconstruction/eflowRec

This merge request affects 12 files:

• Reconstruction/eflowRec/eflowRec/PFCellLevelSubtractionTool.h
• Reconstruction/eflowRec/eflowRec/PFTrackClusterMatchingTool.h
• Reconstruction/eflowRec/eflowRec/PFTrackSelector.h
• Reconstruction/eflowRec/eflowRec/eflowTrackCaloExtensionTool.h
• Reconstruction/eflowRec/python/PFHLTSequence.py
• Reconstruction/eflowRec/python/PFOnlineMon.py
• Reconstruction/eflowRec/share/run_ESDReco_HLT.py
• Reconstruction/eflowRec/src/PFAlgorithm.cxx
• Reconstruction/eflowRec/src/PFCellLevelSubtractionTool.cxx
• Reconstruction/eflowRec/src/PFTrackClusterMatchingTool.cxx
• Reconstruction/eflowRec/src/PFTrackSelector.cxx
• Reconstruction/eflowRec/src/eflowTrackCaloExtensionTool.cxx

Adding @goetz ,@mhodgkin as watchers

added JetEtmiss Reconstruction master review-pending-level-1 labels

added 1 commit

• 2eb26c66 - Removing unnecessary comments.

Compare with previous version

This merge request affects 1 package:

• Reconstruction/eflowRec

This merge request affects 12 files:

• Reconstruction/eflowRec/eflowRec/PFCellLevelSubtractionTool.h
• Reconstruction/eflowRec/eflowRec/PFTrackClusterMatchingTool.h
• Reconstruction/eflowRec/eflowRec/PFTrackSelector.h
• Reconstruction/eflowRec/eflowRec/eflowTrackCaloExtensionTool.h
• Reconstruction/eflowRec/python/PFHLTSequence.py
• Reconstruction/eflowRec/python/PFOnlineMon.py
• Reconstruction/eflowRec/share/run_ESDReco_HLT.py
• Reconstruction/eflowRec/src/PFAlgorithm.cxx
• Reconstruction/eflowRec/src/PFCellLevelSubtractionTool.cxx
• Reconstruction/eflowRec/src/PFTrackClusterMatchingTool.cxx
• Reconstruction/eflowRec/src/PFTrackSelector.cxx
• Reconstruction/eflowRec/src/eflowTrackCaloExtensionTool.cxx

Adding @goetz ,@mhodgkin as watchers

Hi @otheiner,

can you please add the ATLAS bot to your fork as described here?

Thanks, Volker (L1)

CI Result FAILURE (hash 1891d3cb)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44160]

I have added a couple of comments from L1 side. Also, the CI fails due to

AttributeError: 'PFTrackSelector' object has no attribute 'MonTool'

Can you please take a look?

added review-user-action-required label and removed review-pending-level-1 label

CI Result FAILURE (hash 2eb26c66)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44161]

requested review from @ayana

added 1 commit

• 4d5a5321 - Fixing year in copyright

Compare with previous version