Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 193
    • Merge requests 193
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !49124

Merged
Created Dec 14, 2021 by Christos Anastopoulos@christosDeveloper

ATLASRECTS-5012: Migrate LAr/Tile Volume builder to not retrieving the CaloDetDescrManager from the store

  • Overview 11
  • Commits 4
  • Pipelines 4
  • Changes 9

Migrate LAr/Tile Volume builder to not retrieving the CaloDetDescrManager from the store

What we do is

  1. Create ICaloTrackingVolumeBuilder, that accepts the CaloDetDescrManager as argument
  2. Migrate LAr/Tile Volume builder to implement this
  3. Tried also to clean up the headers for these 2. (note to shifter for this MR can not do much for the existing mutable... these will need some further thinking)
  4. Migrate the clients of LAr/Tile Volume to retrieve and pass the CaloDetDescrManager
  5. There are 2 clients the CaloTrackingGeometryBuilder and CaloTrackingGeometryBuilderCond. The later Cond retrieves the CaloDetDescrManager via Conditions the former still goes via the store (legacy way).

ping @tsulaia

Edited Dec 15, 2021 by Christos Anastopoulos
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: CaloVolumeBuilders_CaloDetDescr