Skip to content

Fixing several problems with HLT content in DAOD_PHYSVAL

James Catmore requested to merge jcatmore/athena:master-fix-PHYSVAL into master

ATLFTAGDPD-286

This MR addresses several problems observed in in the slimming mechanism revealed by DAOD_PHYSVAL production in the latest master nighties:

  • fixes an issue where the structure of HLT Aux container names differ from how they were assumed to be, leading to KeyErrors when the contents were being assembled. This is the bug referred to in the above JIRA
  • fixes a bug in the slimming where a container entered into the smart slimming as ContainerAux., intended to mean that all variables should be included, lead to malformed variable lists containing empty strings, in the event that another smart slimming list requested a limited set of variables. Note that ContainerAux. is not the preferred syntax for requesting all variables - AllVariables should normally be used - but in this case there are reasons for the use of this syntax.
  • removes the limited content requested for certain HLT containers in smart slimming, since some slimming is applied for these containers elsewhere, and requesting a specific list of content to be included leads to a mixture of + and - items in the ItemList, which is forbidden. This will inevitably increase the size of the trigger containers stored in the DAODs, but since this is usually only likely to be PHYSVAL plus a limited number of other formats (and not PHYS) this shouldn't have much impact overall on disk space. If this turns out not to be the case, we can re-visit the mechanism by which the variables are removed

Merge request reports