Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 144
    • Merge requests 144
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !49370

clean up legacy ITrackFitter interface methods

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:ITrackFitter_rm_fallback_interf into master Dec 30, 2021
  • Overview 28
  • Commits 5
  • Pipelines 5
  • Changes 29

We have legacy methods in the interface that do :

inline Track*
ITrackFitter::fit(const Track& track,
                  .....) const
{

  return fit(Gaudi::Hive::currentContext(),
             ....)
    .release();
}

i.e they call the new interface (impelement by all fitters)
passing the eventContext and then release() the unique_ptr to a plain one..

Trying to remove them. And do an 1-1 (for now migration of remaining clients).

I expect I have missed some clients . So will let the CI tell me which...

Edited Dec 31, 2021 by Christos Anastopoulos
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ITrackFitter_rm_fallback_interf