Restructure the egamma specific code for caloExtensions

Restracture the egamma specific code for caloExtensions

• Move the code specific to the calo layers egamma needs from the ParticleCaloExtensionTool to the EMExtrapolation Tool
• Factor out in an additional method in the ParticleCaloExtensionTool the the Layers to Surfaces step.
• Migrate the egamma clients, now we can create the target surfaces from the cluster's layers once and re-use them

This merge request affects 7 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs
• Reconstruction/RecoTools/RecoToolInterfaces
• Reconstruction/RecoTools/TrackToCalo
• Reconstruction/egamma/egammaAlgs
• Reconstruction/egamma/egammaInterfaces
• Reconstruction/egamma/egammaTools
• Reconstruction/egamma/egammaTrackTools

Affected files list will not be printed in this case

Adding @goetz ,@dshope as watchers

added Derivation Egamma Reconstruction analysis-review-required master review-pending-level-1 labels

CI Result FAILURE (hash 151bf22b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 3, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 3, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44686]

added 70 commits

• 151bf22b...8c0064ca - 69 commits from branch atlas:master
• ae120f5a - Merge remote-tracking branch 'upstream/master' into egammaCaloExtr_streamline

Compare with previous version

This merge request affects 7 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkHiggs
• Reconstruction/RecoTools/RecoToolInterfaces
• Reconstruction/RecoTools/TrackToCalo
• Reconstruction/egamma/egammaAlgs
• Reconstruction/egamma/egammaInterfaces
• Reconstruction/egamma/egammaTools
• Reconstruction/egamma/egammaTrackTools

Affected files list will not be printed in this case

Adding @goetz ,@dshope as watchers

CI Result SUCCESS (hash ae120f5a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44690]

From a L1 perspective the changes look fine. Moving to L2 for deeper look.

-- L1

added review-pending-level-2 label and removed review-pending-level-1 label

MR is good to approve from L2 side.

Cheers, Abhishek [L2]

added review-approved label and removed review-pending-level-2 label

added analysis-review-approved label and removed analysis-review-required label

mentioned in commit 58b7182f

merged

added sweep:ignore label