Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 138
    • Merge requests 138
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !49638

Draft: TriggerMenuMT Jet - Fixing preselection chain part dictionary to allow for combined chains with presel (ATR-24766)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Claire Antel requested to merge cantel/athena:master_preselfix into master Jan 13, 2022
  • Overview 12
  • Commits 1
  • Pipelines 1
  • Changes 1

This partially addresses the issue in ATR-24766, following the attempted implementation of combined chain HLT_tau20_mediumRNN_tracktwoMVABDT_probe_j45_pf_ftf_preselj20_03dRAB_L1J15, which however failed from a wrong signature and alignmentGroup settings for compiled presel chain parts.

Two changes were made in JetChainConfiguration.py:getJetCaloPreselChainStep

  • Get signature and alignmentGroup from previous last chain part (should be the presel chain part), to overwrite defaults in new chain part which are lists but should be strings
  • Add the etarange explicitly to chainNamePart for the new chain part: The above line fix revealed a crash downstream if no etarange is specified.

This is a temporary fix, as the generation of the presel dictionary should be handled differently, explained by @khoo in ATR-24766.

Requesting to merge this now, so as to no longer block ATR-24031 .

Edited Feb 09, 2022 by Claire Antel
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master_preselfix