Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 235
    • Merge requests 235
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !49771

Merged
Created Jan 19, 2022 by Dan Guest@dguestDeveloper3 of 3 tasks completed3/3 tasks

Trigger: fix b-jet preselection in data

  • Overview 12
  • Commits 6
  • Pipelines 1
  • Changes 4

Followup on !49668 (merged), with fixes to make the code run on data as well.

Currently blocked by !49183 (merged).

This should not change any existing outputs, and the changes do not touch any code that offline flavor tagging uses in production.

In the data case the beamspot uncertainty decorations we rely (stored in EventInfo) aren't present when this code runs, since presumably these correspond to the offline beamspot. To access the online beamspot parameters, I had to schedule these decorations on EventInfo under a different name (prefixed by online). I also had to add some flexibility so some classes could read decorations with the new names.

To Do:

  • Schedule EventInfoBeamSpotDecoratorAlg with modified output keys (for online)
  • Make the beamspot access in PoorMansIpAugmenterAlg configurable
  • Run EventInfoBeamSpotDecoratorAlg in BjetFlavourTaggingConfiguration

Local testing with

  • test_trig_mc_v1Dev_slice_jet_build.py
  • test_trig_data_v1Dev_slice_jet_build.py
Edited Jan 24, 2022 by Dan Guest
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bjet-fix-data