Skip to content

AthenaServices: enable thread-checker for entire package

Frank Winklmeier requested to merge fwinkl/athena:athsvc_thrchk into master

Previously only selected services were enabled for thread-checking. To avoid that new code goes unchecked, revert the logic and check the entire package. Add thread-checker annotations where needed, i.e.:

  • Disable thread-checker for:
    • AthenaEventLoopMgr
    • MixingEventSelector
    • PyAthenaEventLoopMgr
    • some of the testing code
    • and mark PageAccessControlSvc constructor as non-thread-safe.
  • AthenaMtesEventLoopMgr: Explicitly pass the socket name (empty string as default like before) to the relevant yampl functions to avoid warnings about the external static "DEFAULT_ID".
  • CoreDumpSvc: Add thread-checker annotations where needed. CoreDumpSvc is of course mostly not-thread-safe (and does not need to be).
Edited by Frank Winklmeier

Merge request reports