Skip to content
Snippets Groups Projects

Reduce repeated calls to hasBSError

Merged Reduce repeated calls to hasBSError
hzuchen/athena:pixel_clusterization_speed_up into master
All threads resolved!
Merged Zuchen Huang requested to merge hzuchen/athena:pixel_clusterization_speed_up into master
All threads resolved!

We add a new function in PixelConditionTools, which skip the if (hasBSError(moduleHash, ctx)) { return true; } as it was called in first instance of bool PixelConditionsSummaryTool::isGood(const IdentifierHash & moduleHash, const Identifier &elementId, const EventContext& ctx) const

Edited by Zuchen Huang

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • J
    Jakub Kremer @jkremer ·
    Developer

    Hi @hzuchen, I have one small comment above, otherwise the changes look good from L1 perspective.

    Jakub (L1 shifter)

  • Jakub Kremer added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Zuchen Huang added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • InnerDetector/InDetConditions/InDetConditionsSummaryService
    • InnerDetector/InDetConditions/PixelConditionsTools
    • InnerDetector/InDetConditions/SCT_ConditionsTools

    Affected files list will not be printed in this case

    Adding @goetz ,@stsuno ,@lshan ,@battagl ,@sroe as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 68d7d04e)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45820]

  • Zuchen Huang resolved all threads

    resolved all threads

  • Magdalena Slawinska added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Adam Edward Barton merged

    merged

  • Adam Edward Barton mentioned in commit 89b590fd

    mentioned in commit 89b590fd

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply