Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 142
    • Merge requests 142
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !50016

22.0-cleanup-PixelConditionsData

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Shaun Roe requested to merge sroe/athena:22.0-cleanup-PixelConditionsData into master Jan 27, 2022
  • Overview 11
  • Commits 3
  • Pipelines 1
  • Changes 3

This MR addresses ATLASRECTS-4509 by deleting copy and assignment on the PixelOfflineCalibData object. Additional small cleanup also performed (change bare pointer members to unique_ptr). However while doing this I spotted that a 'resize' on the constants vector was used, when I'm (fairly) sure that reserve was intended. The result of the original code would have doubled the size of the constants vector and placed all zeroes in the first half. Thus, if this is ever used, the output of the 'constants' (on file?) will have changed with this MR. For this reason, a Pixel expert (@stsuno, @tlari , @battagl) should take a look at the code.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 22.0-cleanup-PixelConditionsData