22.0-cleanup-PixelConditionsData

This MR addresses ATLASRECTS-4509 by deleting copy and assignment on the PixelOfflineCalibData object. Additional small cleanup also performed (change bare pointer members to unique_ptr). However while doing this I spotted that a 'resize' on the constants vector was used, when I'm (fairly) sure that reserve was intended. The result of the original code would have doubled the size of the constants vector and placed all zeroes in the first half. Thus, if this is ever used, the output of the 'constants' (on file?) will have changed with this MR. For this reason, a Pixel expert (@stsuno, @tlari , @battagl) should take a look at the code.

This merge request affects 2 packages:

• InnerDetector/InDetConditions/PixelConditionsAlgorithms
• InnerDetector/InDetConditions/PixelConditionsData

Affected files list will not be printed in this case

Adding @goetz ,@battagl ,@sroe ,@stsuno ,@lshan as watchers

added InnerDetector master review-pending-level-1 labels

CI Result FAILURE (hash 9eae4e38)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45829]

Changes look good from L1 point of view. AMI issue is unrelated (see ATLASAMI-278) - Approving.

Cheers, Steffen (L1)

removed review-pending-level-1 label

added review-approved label

mentioned in commit 449c808d

merged

Hi, @abarton would it be possible to revert this merge until the CI is working, and/or pixel experts have had a look?

mentioned in commit b1aff816

mentioned in merge request !50045 (merged)

added review-pending-expert label

removed review-approved label

resolved all threads

added sweep:ignore label

@sroe - was this change reviewed/tested by the experts? I do not see it linked here

Hi @gfacini , I dont think so but it raised another issue, which is : Why the trigger is reading conditions from a file at all when it should have been reading them from the database. Finally, I think it was @jmasik fixed the job options, after which this code is no longer used in the trigger. The fix was entered, but I think remains unused.

Thank you, @sroe! The changes to the PixelOfflineCalibCondAlg will not impact offline reconstruction?

Not at all, provided the database is used (which is normally the case). If, for some reason, it is necessary to run from file conditions, this corrects the existing problem anyway. A change would be seen, but it would be in the right direction.

Note replacement MRs and the JIRA discussion: !50129 (merged) (a redo of the bugfix in this MR) !50406 (merged) (correction of the configuration to use DB instead) https://its.cern.ch/jira/browse/ATLASRECTS-6806 (Discussion of the bug and its fixes)