Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 122
    • Merge requests 122
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !50163

RootStorageSvc+DerivationFrameworkTrainsART: Improve testing for index_ref collisions in derivation jobs (see !50140)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alaettin Serhan Mete requested to merge amete/athena:master-improve-index_ref-testing into master Feb 02, 2022
  • Overview 3
  • Commits 3
  • Pipelines 1
  • Changes 6

This MR adds a new script to RootStorageSvc (primarily because this is where the index_ref code resides), that given a ROOT file simply loops over all the events and checks for possible collisions in the index_ref values. This is to catch issues that are discussed in !50140 (merged). The new script is also adopted in the ART tests that run as part of DerivationFrameworkTrainsART. So, if this one gets merged before !50140 (merged) (or whatever MR that fixes the underlying issue) then the relevant ART tests should start failing, meaning they're doing their job.

cc: @gemmeren @mnowak @calpigia @jcatmore

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master-improve-index_ref-testing