Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 144
    • Merge requests 144
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !50224

Make JetSecVertexingAlg.cxx handle nullptr more properly. Instead of skipping the jets with no vertexices (nullptr), assigning default element links

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bingxuan Liu requested to merge biliu/athena:BtaggingELFix into master Feb 04, 2022
  • Overview 19
  • Commits 5
  • Pipelines 1
  • Changes 2

Null pointer is assigned when there are no tacks associated with the jets in the Secondary Vertex and Jet Fitter algorithm. The element links are not set due to the failed cast on the nulls. When resetting the element links afterwards, this triggers errors.

The fix uses the handle's this case in a more proper way. It does not rely on cast any more to determine the algo. Instead it uses the algo name directly and checks whether it is null afterwards. In this way, even when there are no tracks associated with the jets, the default element link is created.

Edited Feb 10, 2022 by Bingxuan Liu
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: BtaggingELFix