Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 182
    • Merge requests 182
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !50409

Cleaning and solving jFEX Small-R jets bug in forward region

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sergi Rodriguez Bosca requested to merge serodrig/athena:jJ_EDM_update into master Feb 11, 2022
  • Overview 11
  • Commits 2
  • Pipelines 2
  • Changes 27

This MR is meant to solve a problem with the jFEX Small-R jets, and also to clean the code to make it more understandable.

  • Cleaning jk_ from most of the containers
  • Changing ATH_MSG_FATAL messages to make it understandable
  • Removed some comments and unused keys
  • Changed in the Run3 jFEX EDM the position of the FWD TT by one in phi -> affects only jJ and jLJ (variable globalPhi)
  • Solved a problem when overlaping with the other half of the detector (phi = 0) (see first picture) 2D_FloatEtaPhi The final distribution for the Small-R jets after solving the bug is: 2D_FloatEtaPhi
Edited Feb 12, 2022 by Sergi Rodriguez Bosca
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jJ_EDM_update