Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 152
    • Merge requests 152
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !50414

BTagging: remove lots of unused tools

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dan Guest requested to merge dguest/athena:cleanup-btagging into master Feb 11, 2022
  • Overview 14
  • Commits 4
  • Pipelines 4
  • Changes 18

This removes a lot of tools that are no longer used. They fall into several groups:

  • Tools that are only referred to by themselves, and have no calls from python.
  • Interface classes with nothing deriving from them.
  • Tools that use outdated interfaces (e.g. JetEvent), which we're unlikely to support in release 22 without a full rewrite.
  • Tools that are both duplicates of other tools, and that only refer to themselves, e.g. BTagSecVertexing

I don't think anything here will be useful to the b-tagging group, so to keep people from getting confused I'm proposing that we remove them.

I also changed the permissions on some source files that were set to executable.

Still others may feel differently. I'm marking this as a draft until @thuffman and @duperrin have had a look: this is no rush, just housecleaning that someone should eventually get to.

Edited Feb 15, 2022 by Dan Guest
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: cleanup-btagging