Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 139
    • Merge requests 139
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !50420

IsCentralSeed Fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicholas Luongo requested to merge nicholas/athena:iscentralseed_fix into master Feb 12, 2022
  • Overview 37
  • Commits 2
  • Pipelines 7
  • Changes 3

This change fixes a bug in the bitwise eFEX tau creation code. The algorithm searches for local maxima in towers and creates a TOB when one is found. However, the current code only checks a subset of the cells surrounding a candidate.

This has lead to duplicate HLT taus appearing as documented here: https://its.cern.ch/jira/browse/ATR-24908

Because this is enforcing stricter criteria on the creation of a tau TOB, we expect strictly fewer to be output. Therefore updates to the reference value for the trigP1 and trigAna tests are included.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: iscentralseed_fix