Skip to content
Snippets Groups Projects

NSW Trigger Simulation - Cleanup package

Merged Francesco Giuseppe Gravili requested to merge fgravili/athena:simplify into master
All threads resolved!

In order to make the transition of the package easier for athenaMT, a general cleanup of the package was done:

  • Removed the monitoring tool as well as the corresponding output (actually empty) root file, being saved on disk
  • Removed declareProperty instances and replaced them with new syntax, both for algorithms and variables (the remaining sTGC tool will move to the new format once fixed)
  • Removed unused flags and functions
  • Moved all include instances to the header file
  • Adjusted spaces and indentation

./cc-ing @iodice @rosati @vadamico

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Clara Nellist
  • Changes look fine and the CI is good. Happy to approve when the discussions have been resolved. Clara (L1)

  • resolved all threads

  • Hi @cnellist, thanks! Discussions resolved, I hope my answers are fine

  • Yep, thanks @fgravili! Approving. Clara (L1)

  • mentioned in commit 8c1c06d2

  • Please register or sign in to reply
    Loading