NSW Trigger Simulation - Cleanup package
In order to make the transition of the package easier for athenaMT, a general cleanup of the package was done:
- Removed the monitoring tool as well as the corresponding output (actually empty) root file, being saved on disk
- Removed
declareProperty
instances and replaced them with new syntax, both for algorithms and variables (the remaining sTGC tool will move to the new format once fixed) - Removed unused flags and functions
- Moved all include instances to the header file
- Adjusted spaces and indentation
Merge request reports
Activity
This merge request affects 1 package:
- Trigger/TrigT1/TrigT1NSW
This merge request affects 4 files:
- Trigger/TrigT1/TrigT1NSW/python/TrigT1NSWConfig.py
- Trigger/TrigT1/TrigT1NSW/share/NSWL1.py
- Trigger/TrigT1/TrigT1NSW/src/NSWL1Simulation.cxx
- Trigger/TrigT1/TrigT1NSW/src/NSWL1Simulation.h
added Trigger master review-pending-level-1 labels
CI Result SUCCESS (hash 18757812)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 46833]- Resolved by Francesco Giuseppe Gravili
- Resolved by Francesco Giuseppe Gravili
added review-user-action-required label and removed review-pending-level-1 label
Hi @cnellist, thanks! Discussions resolved, I hope my answers are fine
Yep, thanks @fgravili! Approving. Clara (L1)
added review-approved label and removed review-user-action-required label
mentioned in commit 8c1c06d2
added sweep:ignore label