[ATR-20810][ATR-24394][ATR-19834] Propagate BunchGroup into in-file metadata, add referencing key into the event store
This follows from !50215 (merged) (thanks @abarton) and compliments !47861 (merged)
BunchGroup config goes into the CondStore -> is written to the in-file metadata -> is picked up by the TrigConf::xAODConfigSvc
This MR fills in this middle part.
Unique bunch group JSONS are written into the metadata store as they are encountered, based on the bunchgroup key in every event.
Note: These JSONs are very small, few kb each uncompressed. We will typically have one per used LHC filling scheme. We only need to keep in a given AOD the JSONs which correspond to events in the AOD
In every event we write a xAOD::BunchConfKey
which associates the event with an entry in the metadata store via the key value. This works exactly like the existing xAOD:TrigConfKeys
key triplet.
Note: The payload of xAOD::BunchConfKey
is just a single int32 per event.
This resolves a long-standing but minor* issue from Run2 where we did not keep track of the BunchGroup key independently from the L1 and HLT prescale keys in the in-file payloads. As we should, all three can change independently of each other on lumi block boundaries.
(Minor in that it is very rare for the BunchGroup to change during stable beams)
Merge request reports
Activity
This merge request affects 5 packages:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore
- Trigger/TrigConfiguration/TrigConfxAOD
- Trigger/TrigSteer/HLTSeeding
- Trigger/TriggerCommon/TrigEDMConfig
- Trigger/TriggerCommon/TriggerJobOpts
Affected files list will not be printed in this case
Adding @sutt ,@jmharris ,@orlando ,@cmorenom ,@mark ,@tamartin ,@paulama ,@okuprash ,@asonay ,@bernius ,@rbielski as watchers
added Run2-DataReco-output-changed label
❎ CI Result FAILURE (hash 6ad4a7b7)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals ✅ ✅ ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ ✅ ✅ required tests ⭕ ✅ ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ ✅ ✅ Full details available on this CI monitor view. Check the JIRA CI status board for known problems
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthAnalysis: number of compilation errors 0, warnings 0
✅ DetCommon: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 46953]This merge request affects 5 packages:
- PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore
- Trigger/TrigConfiguration/TrigConfxAOD
- Trigger/TrigSteer/HLTSeeding
- Trigger/TriggerCommon/TrigEDMConfig
- Trigger/TriggerCommon/TriggerJobOpts
Affected files list will not be printed in this case
Adding @sutt ,@jmharris ,@orlando ,@cmorenom ,@mark ,@tamartin ,@paulama ,@okuprash ,@asonay ,@bernius ,@rbielski as watchers
❎ CI Result FAILURE (hash 4f6cff03)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals ✅ ✅ ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ ✅ ✅ required tests ⭕ ✅ ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ ✅ ✅ Full details available on this CI monitor view. Check the JIRA CI status board for known problems
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthAnalysis: number of compilation errors 0, warnings 0
✅ DetCommon: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 46979]added analysis-review-approved label and removed analysis-review-required label
added review-pending-level-2 label and removed review-pending-level-1 label
Hi @mhodgkin, @goetz - would you like to discuss this in a reco meeting due to the Run2-DataReco-output-changed ?
- Resolved by Pavol Strizenec
Hi,
If I understand correctly this only adds new information and does not change existing information?
Cheers,
Mark
added review-approved label and removed review-pending-level-2 label