Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 182
    • Merge requests 182
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !50591

fix urgent efex numbering bug in the bitwise simulation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alison Elliot requested to merge afaulkne/athena:master-efex-bugfix into master Feb 17, 2022
  • Overview 27
  • Commits 7
  • Pipelines 7
  • Changes 4

As reported in the TGM - https://indico.cern.ch/event/1129558/#8-l1-simulation-update-l1-calo a fix to the eFEX inefficiency at |eta|>0.8 has been found. The issue was a mismatch in the numbering scheme that is used to simulate the different eFEXes.

LVL1RoIs_output_fixedFresh.pdf - slides 20 and 23 show that the fix changes only the outer eta regions of the egamma and tau algorithms, but not the et distributions or phi locations of the TOBs.

This merge request is urgently needed for the next round of validation. @dzanzi @tamartin @aranzazu @okumura @vmartin

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master-efex-bugfix