Skip to content

New module config cond alg to be configured per run period

Nicholas Styles requested to merge nstyles/athena:master-newPixelModuleConfCondAlg into master

As mentioned in !50573 (merged) the configuration of pixel module properties for ITk in particular is a bit awkward, due to the structure of the alg, which has different properties for different run periods which get set all together in single config, rather than an alg with fewer, more generic, properties which is then just configured differently per period.

This very quick first attempt tries to improve this by splitting off the ITk part into a separate alg (with very similar functionality) to avoid having a binding between ITk properties in old-style (where they are not used) and new-style config which have to be synchronized.

Eventually Run 1/2/3 could also move to use this alg instead with appropriate configuration, if agreed.

EDIT: after discussion in comments, the following plan was made

  • Add the new alg for ITk use
  • Clean up the config for the current detector using the old alg
  • Develop conditions data to hold this information and test reading it from conditions instead of config with ITk
  • If this all works, extend the conditions to contain also the current detector and use the new alg + conditions there too.

FYI @sroe @tadej @tstreble @stsuno

Edited by Nicholas Styles

Merge request reports