Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 160
    • Merge requests 160
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !50633

gFEX mapping update in phi

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Cecilia Tosciri requested to merge ctosciri/athena:gFEX_MappingUpdatePhi into master Feb 19, 2022
  • Overview 3
  • Commits 2
  • Pipelines 1
  • Changes 10

With this MR the phi binning of the gTowers in the most forward region is updated in the simulation. Changes reflect the actual gTower binning used in the firmware. The changes required to modify the gTowerBuilder class, the supercells assignment in the gSuperCellTowerMapper class, as well as the gFEXSim, gFEXSysSim, gFEXFPGA tools where the gTowers are used. The new binning has been validated at every step of the simulation. Additionally, the use of constant values for indicating the number of eta and phi bins has been has been expanded to improve code readability.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gFEX_MappingUpdatePhi