Skip to content

AthenaConfiguration: implement VarHandleKey property semantics

Frank Winklmeier requested to merge fwinkl/athena:vhk_semantics into master

Implement/fix the VarHandleKey property semantics and implement unit test. Applies to Read/Write/Cond/DecorHandleKey and ensures that assignments of str and DataHandle work as expected.

Some notes:

  • While previously MyAlg.DH = "dh" would turn DH into a str, now it correctly preserves its DataHandle type. This required fixes in various places where the code incorrectly assumed str type.
  • Note that data handle key arrays, are still plain lists of str.
  • This behavior matches now the old-style Configurables.

This also fixes potential problems in mixed job options as observed in !46900 (comment 4960475).

Edited by Frank Winklmeier

Merge request reports