Skip to content
Snippets Groups Projects

Removed Physics folder, updated webdisplays, split track folder, formatted code.

Merged Ruby Alice Molly Ferguson requested to merge (removed):master into master
All threads resolved!

Removed the physics folder from Data Quality (in histogram algorithm and webdisplays)

Went from Track/all histograms to Track/allTracks and Track/LeadTracks (changes in both histogram algorithm and webdisplays)

Updated the other webdisplays to be the same as the collisions_run

Tidied the format of code in tauMonitorAlgorithm.cxx

Merge request reports

Approval is optional

Merged by avatar (Jun 18, 2025 12:22pm UTC)

Merge details

  • Changes merged into master with e59a7425 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • There are several instances of commented code that should probably be removed. Otherwise the changes look fine.

    Jason (L1)

  • added 1 commit

    Compare with previous version

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 172K in file DataQuality/DataQualityConfigurations/config/Tau/collisions_minutes10.config

    :pencil: 172K in file DataQuality/DataQualityConfigurations/config/Tau/heavyions_run.config

    :pencil: 172K in file DataQuality/DataQualityConfigurations/config/Tau/collisions_run.config

  • This merge request affects 2 packages:

    • DataQuality/DataQualityConfigurations
    • Reconstruction/tauMonitoring

    Affected files list will not be printed in this case

    Adding @goetz as watcher

  • :white_check_mark: CI Result SUCCESS (hash f6c4bd0e)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 48208]

  • Hi @rferguso, please resolve all open threads

    Sergei L1

  • Jakub Kremer resolved all threads

    resolved all threads

  • Changes look good, previous comments have been addressed - approving.

    Jakub (L1 shifter)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit e59a7425

  • Please register or sign in to reply
    Loading