Muon Momentum calib (MMC) precision rel21.2 calibration in master

This MR ports over all software development from the 21.2 branch that implements the final precision Rel 21.2 recommendation.

The initial sweeps to master were rejected due to indentation differences between the two branches. These are being fixed in a different MR 50762

marked this merge request as ready

Tagging our well admired friend the @atlasbot

WARNING: big files (>100K) are found in the changeset

184K in file PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibrationAndSmearingTool.cxx

This merge request affects 1 package:

• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections

This merge request affects 6 files:

• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/CMakeLists.txt
• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/MuonMomentumCorrections/MuonCalibrationAndSmearingTool.h
• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/MuonMomentumCorrections/MuonCalibrationPeriodTool.h
• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibrationAndSmearingTool.cxx
• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibrationPeriodTool.cxx
• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/util/MCAST_Tester.cxx

Adding @fsforza ,@stavrop ,@szambito ,@jojungge ,@mvanadia ,@gabarone ,@gartoni as watchers

added Analysis analysis-review-required master review-pending-level-1 labels

CI Result FAILURE (hash d4e0c1e0)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 47725]

There seems to be a problem with this MR:

MuonCalibrationPeriodToolINFO    The assignment of the calibration tools will be based on the random run number. Please make sure to call the pileup-tool before applying this tool
MuonCalibrationPeriodToolFATAL   /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibrationPeriodTool.cxx:111 (virtual StatusCode CP::MuonCalibrationPeriodTool::initialize()): Invalid  calibration mode: -1 Allowed modes are correctData_CB(0) correctData_IDMS (1) or notCorrectData_IDMS (2)
terminate called after throwing an instance of 'std::runtime_error'
  what():  top::check: Failed to set initialize MuonCalibrationPeriodTool
 *** Break *** abort
    __boot()
    import os
 *** Break *** abort
    __boot()
    import os
CI Integration Test : DAOD_PHYS DATA
CI Integration Test : Using cutfile /build2/ci-builds/master/AnalysisBase/build/AnalysisBase/x86_64-centos7-gcc11-opt/data/TopAnalysis/validation-cuts.txt
CI Integration Test : Using inputfile /cvmfs/atlas.cern.ch/repo/sw/database/GroupData/dev/AnalysisTop/ContinuousIntegration/R22/Data/p4844/DAOD_PHYS.data18_r13100_p4844.pool.root
Error in DAOD_PHYS Data

Could you have a look, @sabidi?

Cheers, Martin (L1)

added analysis-review-expert label

removed analysis-review-required label

This seems to be a bit stuck, so flagging it analysis-review-expert and tagging @krumnack (please let me know if I shall tag somebody else, instructions are not clear to me in this respect). Cheers Monica

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• b085c5f9 - fix for failing test

Compare with previous version

WARNING: big files (>100K) are found in the changeset

184K in file PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibrationAndSmearingTool.cxx

This merge request affects 2 packages:

• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections
• PhysicsAnalysis/TopPhys/xAOD/TopCPTools

Affected files list will not be printed in this case

Adding @fsforza ,@cabrera ,@stavrop ,@szambito ,@omajersk ,@jojungge ,@bbullard ,@mvanadia ,@tdado ,@gabarone ,@gartoni as watchers

added AnalysisTop review-pending-level-1 labels and removed review-user-action-required label

CI Result FAILURE (hash b085c5f9)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 47873]

resolved all threads