Retrieve relevant layers from networks used to predict the longitudinal hit position and fix GAN code using those networks

News:

• Read relevant layers from the JSON files (networks)
• Modify the GAN code to ensure that simulate from TFCSPredictExtrapWeights runs before simulate_hit() is called
• Improve handling of errors. For example, now if within simulate_hit() extrapolations are missing (meaning simulate() didn't run), then return FCSFatal

FYI: @mduehrss

marked this merge request as draft

I marked the MR as draft by hand, since the WIP: in the title seems to no longer do this automatically (using Draft: should work). If this is not intended and the MR is ready for review, please make sure it is labelled accordingly.

Jakub (L1 shifter)

added 1 commit

• 1574c721 - Improve handling of errors and fix for GAN

Compare with previous version

changed the description

added 18 commits

• 1574c721...3574c8fb - 17 commits from branch atlas:21.0
• b3b49f35 - Merge tag 'nightly/21.0/2022-04-16T2123' into ReadLayersFromJSONsNNbasedExtrapWeights

Compare with previous version

marked this merge request as ready

changed title from Draft: WIP: Read layers from jsons to Read layers from jsons

changed the description

added 21.0 label

added Simulation label

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

This merge request affects 2 files:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGAN.cxx
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc as watchers

added review-pending-level-1 label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result SUCCESS (hash b3b49f35)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 166
AthDataQuality: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 7
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52239]

Jenkins please retry a build

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

This merge request affects 2 files:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGAN.cxx
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc as watchers

CI Result SUCCESS (hash b3b49f35)

	Athena	AthDataQuality	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52319]

Hi @jbossios, looks ok, but can you maybe make the title a bit more descriptive?

removed review-pending-level-1 label