Skip to content

Revision of NSW segment making and related codes

Stylianos Angelidakis requested to merge (removed):bug_fixes into master

This MR contains several optimizations and bug fixes. The revision was initially triggered by the attempt to implement B-Lines --> found that sTGC clusters were not getting calibrated --> found that segments were not receiving phi seeds and so on). Stylistic changes (applied Johannes' indentation) was necessary for this.

MuonClusterSegmentFinderTool:

  • Major revision with performance optimizations and bug fixes that significantly improve the observed residuals.
  • Change in MM seeding: An eta segment will be (phi-)seeded by its own stereo strips instead of seeding from any combination of stereo strips in the sector.

sTgcRdoToPrepDataToolCore:

  • Removing clusterization for pads and wires after discussion with Stefano.
  • Loops, e.g. here, add a new hit if there's no other hit with smaller time yet added. New: they will replace an existing hit with larger time.

SimpleSTgcClusterBuilderTool:

  • Fixing wrong treatment of unsigned ints in the conditionals.
Edited by Stylianos Angelidakis

Merge request reports