Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 140
    • Merge requests 140
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !51220

Clean out legacy methods of CaloClusterStoreHelper

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Walter Lampl requested to merge wlampl/athena:CaloClusterStoreHelperCleanup into master Mar 14, 2022
  • Overview 4
  • Commits 5
  • Pipelines 1
  • Changes 12

The CaloClusterStoreHelper had a few legacy methods to support pre-MT workflows. This MR deletes these methods and migrates the last remaining client (CalibHitToCaloCellTool) to DataHandles.

I am unsure if CalibHitToCaloCellTool is still used in practice, it is only linked from DerivationFrameworkEGamma/TruthCaloShowerDecorator. The cluster-building of it looks a bit fishy to me (might make sense on a single-electron sample w/o noise)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: CaloClusterStoreHelperCleanup