Skip to content

Cleanup PixelChargeCalibCondData, part 1

Tadej Novak requested to merge tadej/athena:pixel/chargecalib-cleanup into master

First part of cleanup of PixelChargeCalibCondData:

  • avoid as much casting as possible: already pass unsigned int arguments
  • throw an exception if going out of bounds
  • set a vector per module hash and do not do silent appends
  • simplify data storage to a map of diode types and module vectors

Keeping draft while running more tests but already get feedback.

/cc @stsuno @mvanadia @sroe @nstyles

Edited by Tadej Novak

Merge request reports