Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 135
    • Merge requests 135
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !51879

FCS shape tuning to data bug fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Joshua Falco Beirer requested to merge jbeirer/athena:21.0-fixedLateralShapeTuning into 21.0 Apr 04, 2022
  • Overview 10
  • Commits 5
  • Pipelines 3
  • Changes 2

This MR:

  • fixes a bug where phiScaleFactor would get overwritten with the etaScaleFactor in the 2D phi_s - eta_s scaling model
  • fixes an issue where we would get a crash in the FCS standalone param file merging, when the class is called using its default constructor, but no model parameter file path is defined
  • improves debug level verbosity
  • removes arguments from constructor and implements separate method to initialise data tuning
Edited Apr 04, 2022 by Joshua Falco Beirer
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 21.0-fixedLateralShapeTuning