TrigNavigation: thread-checker fixes
A first set of fixes to make the TrigNavigation package eventually pass the thread-checker:
- Delete RoICacheHelper that was only useful when we were still running the legacy trigger. It's not needed for reading the Navigation.
- Remove the EDM size recording into StoreGate as this is certainly not useful anymore and is certainly not MT-friendly.
- Replace the
std::map
in formatSGKey with atbb::concurrent_unordered_map
. This might be overkill but on the other side, if speed was an issue, we would have changed to astd::unordered_map
already a while ago.
Also delete unused ComboIterator forwarding header, disable thread-checking for testing code and various minor const-correctness fixes.