Skip to content

Implement new BMA and BCM additions to CTP [ATR-25388, ATR-23522]

Teng Jian Khoo requested to merge khoo/athena:master-TMMT-BCM_BMA into master

Updating L1 menu to match the latest CTP configuration:

  1. For ATR-25388 add 2 CTP inputs for BMA0,1 to be used as monitoring inputs for a Phase-II demonstrator. @amarzin, I added the 2 connections only, and defined corresponding thresholds but no L1 items using these. Actually I am not certain if the thresholds themselves are needed. Every CTPIN (except a couple of jet ones) should automatically be included in the monitoring.
  2. For ATR-23522 add 2 CTP inputs for BCM_6,7, corresponding to items BCM_2A,2C in various bunchgroups. Additional changes to the L1 menu and monitoring as listed below:
  • Removed all ABORTGAPNOCALIB L1 items and any corresponding HLT. We still have some references in the parsing because they are used for the Enhanced Bias menu -- I suggest to clean up when we update the EB lists.
  • Substituted FIRSTINTRAIN bunchgroup condition for ABORTGAPNOTCALIB
  • Defined 2A,2C in the following bunchgroups: EMPTY, CALIB, UNPAIRED_ISO/NONISO, UNPAIREDB1/2 (for 2A,2C respectively), FIRSTINTRAIN, and added all of these items to the L1Background seed.
  • Swapped L1 items as recommended by @shanisch in all L1 menus.
  • Switched high frequency CTP monitoring to cover 2A/C_UNPAIRED_ISO instead of the older AC/CA/Wide items as requested by @huu
Edited by Teng Jian Khoo

Merge request reports