Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 139
    • Merge requests 139
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !52633

Introduce flat container to replace the CaloClusterROI collection.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Goetz Gaycken requested to merge goetz/athena:CaloClusterROI_master_streamline into master Apr 27, 2022
  • Overview 49
  • Commits 10
  • Pipelines 7
  • Changes 63

Originally there was the CaloClusterROI_Selector which creates CaloClusterROIs from selected calorimeter clusters. These objects are used in several algorithms. However none of the algorithms uses these CaloClusterROI objects directly. Most algorithms create flat vectors from the CaloClusterROI_Collection. The latter is done once per event which leads to lock contention in the InDetDenseEnvAmbiTrackSelectionTool.

This MR replace the CaloClusterROIs by something that can be directly used by the client algorithms. This avoids executing the same coordinate transformations and creation of the flat vectors at several places, and mitigates the lock contention (there is still a ReadHandle being created by the InDetDenseEnvAmbiTrackSelectionTool for each track).

Lock contention in the InDetDenseEnvAmbiTrackSelectionTool is significantly reduced (at large number of threads). And there seems to be a small overall improvement of 1-2%. However the latter may not be significant.

Edited Apr 29, 2022 by Goetz Gaycken
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: CaloClusterROI_master_streamline