Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 138
    • Merge requests 138
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !52750

PanTauAlgs: thread-safety fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Frank Winklmeier requested to merge fwinkl/athena:pantau into master Apr 29, 2022
  • Overview 3
  • Commits 3
  • Pipelines 1
  • Changes 6

Several fixes to get the package closer to pass the thread-checker:

  • Remove caching of p4 in PanTauSeed and TauConstituent .The caching of the 4-momentum is not thread-safe. If this is really needed one needs to be implement this properly.
  • PanTauSeed: avoid const_cast by storing non-const pointer to TauJet
  • add const-correct getFeatures and getPFO methods

However, the package still has several const_casts that are used to modify EDM objects in place. This is likely not thread-safe at all and needs to be looked at by experts. cc @martindl

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: pantau