Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 135
    • Merge requests 135
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !52808

Fix and prevent irreproducible ordering of Trigger EDM list

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rafal Bielski requested to merge rbielski/athena:trig-edm-ordering into master May 02, 2022
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 4

Trigger configuration must be completely reproducible, including ordering of all job properties. One of the properties is built from the Run-3 Trigger EDM list which recently introduced an irreproducibility by using list(set(something)) in !52412 (merged). Fix this issue by sorting this list, and add a unit test to prevent such bugs in the future.

The new unit test runs in 6 seconds on my laptop.

Fixes ATR-25096

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: trig-edm-ordering