Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 143
    • Merge requests 143
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !52811

Updated Pixel charge calibration condition algorithms for Run 3 in relevant CA configs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Thomas Strebler requested to merge tstreble/athena:Run3PixelChargeCA into master May 02, 2022
  • Overview 7
  • Commits 1
  • Pipelines 1
  • Changes 3

This MR updates the ComponentAccumulator config of the pixel charge calibration to use the new Run3 condition algorithm for the pixel NN (+ other minor algorithms not run in the main reconstruction). This update solves a very large fraction of the differences still observed in the q445 Run 3 test, between the CA and the legacy configs.

For the record, the remaining discrepancies are mostly from truth collections + a few from Taus + a background flag

Py:diff-root         INFO Found [11017] identical leaves
Py:diff-root         INFO Found [5993] different leaves
Py:diff-root         INFO  [EventInfoAux.backgroundFlags]: 1 leaves differ
Py:diff-root         INFO  [TauNeutralParticleFlowObjectsAuxDyn.cellBased_EM1CoreFrac]: 1 leaves differ
Py:diff-root         INFO  [TauPi0Clusters_links.m_weights]: 28 leaves differ
Py:diff-root         INFO  [TruthEventsAux.crossSection]: 1 leaves differ
Py:diff-root         INFO  [TruthEventsAux.crossSectionError]: 1 leaves differ
Py:diff-root         INFO  [TruthParticlesAux.barcode]: 629 leaves differ
Py:diff-root         INFO  [TruthParticlesAux.e]: 629 leaves differ
Py:diff-root         INFO  [TruthParticlesAux.m]: 419 leaves differ
Py:diff-root         INFO  [TruthParticlesAux.pdgId]: 425 leaves differ
Py:diff-root         INFO  [TruthParticlesAux.px]: 627 leaves differ
Py:diff-root         INFO  [TruthParticlesAux.py]: 627 leaves differ
Py:diff-root         INFO  [TruthParticlesAux.pz]: 629 leaves differ
Py:diff-root         INFO  [TruthParticlesAux.status]: 347 leaves differ
Py:diff-root         INFO  [TruthParticlesAuxDyn.polarizationPhi]: 22 leaves differ
Py:diff-root         INFO  [TruthParticlesAuxDyn.polarizationTheta]: 22 leaves differ
Py:diff-root         INFO  [TruthVerticesAux.barcode]: 445 leaves differ
Py:diff-root         INFO  [TruthVerticesAux.id]: 179 leaves differ
Py:diff-root         INFO  [TruthVerticesAux.t]: 246 leaves differ
Py:diff-root         INFO  [TruthVerticesAux.x]: 240 leaves differ
Py:diff-root         INFO  [TruthVerticesAux.y]: 237 leaves differ
Py:diff-root         INFO  [TruthVerticesAux.z]: 238 leaves differ

FYI @goetz @mhodgkin @tadej

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: Run3PixelChargeCA