Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 138
    • Merge requests 138
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !52881

TrigComposite::derivesFromIParticle Return false where no base information is available

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jon Burr requested to merge jburr/athena:TrigCompositeBaseCheckingFix into master May 04, 2022
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

The problem described in !52816 (merged) turns out to be due to this function, where if no SG::BaseInfoBase is available for a clid it returns true, meaning that where we don't have base information we assume that everything inherits from IParticle. However, the main reason we do not have this information available is because no-one has called one of the DATAVECTOR_BASE macros, i.e. no-one has told us anything about bases. In these cases it seems safest to return false (i.e. where we don't have base information we assume no inheritance).

This should fix the crash seen in that other MR.

Tagging @tamartin and @jcatmore for info.

Edited May 06, 2022 by Jon Burr
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: TrigCompositeBaseCheckingFix