Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 134
    • Merge requests 134
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !53014

High Eta egamma Fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nicholas Luongo requested to merge nicholas/athena:higheta_eg_fix into master May 07, 2022
  • Overview 10
  • Commits 4
  • Pipelines 2
  • Changes 5

Fix an issue with eFEX egamma where TOBs were not being created at highest eta values.

This was due to the fact that at these eta values we are on the edge of eFEX and therefore the central tower is not fully surrounded. If we were to run the algorithm we would be checking non-existent towers and failing. Now we pass the eFEX and FPGA IDs into the algorithm so it is aware of when it is in an edge environment. When that is the case it defaults non-existent cell energies to zero in TOB energy and isolation calculations.

This is the same fix as was applied here for taus: !52609 (merged)

Trigger reference counts are also being updated. Note that tau counts should strictly increase as a result of this change.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: higheta_eg_fix