Regularise the construction of the ChainStrings

Issue with the ordering of the components in ythe chainstraing cause issues is different places notably where some "extra" or "te" flags are included, or not etc. In addition, we have lots of code which strip down, and rebuild the ChainStrings all over the place, so this should hopefully allow up to remove most of that and just use the ChainStrings directly

This merge request affects 1 package:

• Trigger/TrigAnalysis/TrigInDetAnalysisExample

This merge request affects 2 files:

• Trigger/TrigAnalysis/TrigInDetAnalysisExample/TrigInDetAnalysisExample/ChainString.h
• Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/ChainString.cxx

Adding @sutt ,@mvozak ,@nagano as watchers

added Trigger master review-pending-level-1 labels

CI integration tests are cancelled because of compilation error(s)

CI Result FAILURE (hash 9492973e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51865]

added 1 commit

• c8deac8d - aargh

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigAnalysis/TrigInDetAnalysisExample

This merge request affects 2 files:

• Trigger/TrigAnalysis/TrigInDetAnalysisExample/TrigInDetAnalysisExample/ChainString.h
• Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/ChainString.cxx

Adding @sutt ,@mvozak ,@nagano as watchers

marked this merge request as draft

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash c8deac8d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51872]

added 1 commit

• cf165755 - suck

Compare with previous version

marked this merge request as ready

This merge request affects 1 package:

• Trigger/TrigAnalysis/TrigInDetAnalysisExample

This merge request affects 3 files:

• Trigger/TrigAnalysis/TrigInDetAnalysisExample/TrigInDetAnalysisExample/ChainString.h
• Trigger/TrigAnalysis/TrigInDetAnalysisExample/python/chainString.py
• Trigger/TrigAnalysis/TrigInDetAnalysisExample/src/ChainString.cxx

Adding @sutt ,@mvozak ,@nagano as watchers

The system determined that CI tests (with names matching "^CITest_SimulationRun(2|3)FullSim.*$") are not needed for this code change. They are not run. This is not an indicator to restart the job.

CI Result SUCCESS (hash cf165755)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 51880]

Changes look good from L1 side - approving.

Jakub (L1 shifter)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 28bf0c50

merged

added sweep:ignore label