Skip to content

InnerDetector: Sweep changes for strip endcap polar co-ordinates from 21.9

James Smith requested to merge jlsmith/athena:dev/master/PCintegration into master

This is a manual sweep of the changes from !46959 (merged).

A bug fix with the order of co-ordinates in DetectorDescription/ReadoutGeometryBase/src/SolidStateDetectorElementBase.cxx was also made.

Standard tests RunUpgradeTests.log were run with all tests passing. There were a number of warnings, mostly concerning geometry differences, BTag and TruthParticleAuxContainers.

DCube plots comparing the outputs in the cartesian and polar case vs an unmodified version of Athena are available at [cartesian plots] and [polar plots]. The cartesian plots are identical; the polar plots have differences for ITkStrip/m_h_globalX, ITkStrip/m_h_globalY, and ITkStrip/m_h_globalXY.

h1r_c50c73f8-16bc-4a11-aa51-116ad83a3a0d

h1d_7aff0e23-9b78-4315-a3b2-cd582aac525a

h1r_8c94b1c3-de4b-4eec-9012-96461661d8ac

h1d_4f734520-41a9-457a-8782-10ed88465ae1

I can't see any systematic difference here, more like a constant noise term. I'll investigate these numbers and where the difference comes from.

However, this is only in the polar case, which is never used unless a flag is manually added to the ITk Layouts, so this will not affect any existing workflows. Therefore I'd like to move forward with this MR.

This is part of ATLITKSW-42.

Tags: @nstyles @hhayward @tadej @pagessin

Edited by James Smith

Merge request reports