Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 141
    • Merge requests 141
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !53229

Merged
Created May 13, 2022 by Mark Hodgkinson@mhodgkinDeveloper

Bug fix for neutral FlowElement created in jet finding

  • Overview 29
  • Commits 16
  • Changes 8

Currently during jet finding JetPFlowSelectionAlg creates new neutral FlowElements. In the first version of this code only a 4-vector was set - this lead to crashes in AODtodAOD jobs which was previously fixed by adding a needed missing moment. This MR adds all standard data to these newly created FlowElements, because some of it is required for jet calibration etc. The fix migrates code to set this data to a helper class in PFlowUtils which is used from both PFNeutralFlowElementCreatorAlgorithm in eflowRec and JetPFlowSelectionAlg in the jet packages. Thus there is no code duplication. The migration uncovered a bug whereby ENG_BAD_CELLS had been set twice in PFNeutralFlowElementCreatorAlgorithm, instead of setting both ENG_BAD_CELLS and N_BAD_CELLS. Thus ESD/AOD content changes due to this fix. Furthermore jet level quantities change due to the fix and hence all trigger jet based quantities.

Edited May 13, 2022 by Christos Anastopoulos
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: mhodgkin_reorganiseNeutralFE