Skip to content
Snippets Groups Projects

Add tests for the flavor tagging EDM

Merged Dan Guest requested to merge dguest/athena:add-ftag-tests into master

This moves some tests for the flavor tagging EDM into FlavourTaggingTests to consolidate them.

Also adds a new test focused on checking the links to associated particles.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Changes look fine from L1 point of view. Only was a little confused by the messaging. Passing on to L2 in the meantime to cross check that the CMakeLists are correctly set up.

    Kira (L1)

  • Hi,

    looks good apart from the unclear reason why std::cout is being used instead of the messaging service, and also why there is a char string rather than std::string. Once this is clear it will be good to go.

    James (L2)

  • Dan Guest added 1 commit

    added 1 commit

    • 65297e0d - use std::string rather than char, more consistent use of output streams

    Compare with previous version

  • This merge request affects 4 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
    • PhysicsAnalysis/JetTagging/FlavourTaggingTests
    • Projects/AnalysisBase
    • Projects/AthAnalysis

    Affected files list will not be printed in this case

    Adding @nishu ,@rcreager ,@duperrin ,@krumnack ,@sanmay ,@akraszna ,@bdong ,@rbianchi as watchers

  • Dan Guest added 1 commit

    added 1 commit

    Compare with previous version

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • This merge request affects 4 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag
    • PhysicsAnalysis/JetTagging/FlavourTaggingTests
    • Projects/AnalysisBase
    • Projects/AthAnalysis

    Affected files list will not be printed in this case

    Adding @nishu ,@rcreager ,@duperrin ,@krumnack ,@sanmay ,@akraszna ,@bdong ,@rbianchi as watchers

  • :white_check_mark: CI Result SUCCESS (hash 65297e0d)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52246]

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading