Skip to content

TrigHTTHough 1. fix clang warning 2. fix cppcheck, clang-tidy unint member variables

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:TrigHTTHough_unit_members into master

TrigHTTHough

  1. fix clang warning on unused functions
  2. fix cppcheck, clang-tidy unint member variables

1 appears in out clang14 builds http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/MASTERWebArea/ardoc_web_areamaster64BC7AthenaOpt/ARDOC_Log_2022-05-13T2101/Trigger_EFTracking_EFTrackingSim_TrigHTTHough.html

/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/EFTracking/EFTrackingSim/TrigHTTHough/src/HTTPhiRoadFilterTool.cxx:121:27: warning: unused function 'to_string' [-Wunused-function]
static inline std::string to_string(std::vector<int> v)
                          ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/EFTracking/EFTrackingSim/TrigHTTHough/src/HTTHough1DShiftTool.cxx:457:27: warning: unused function 'to_string' [-Wunused-function]
static inline std::string to_string(const std::vector<int> &v)
                          ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/EFTracking/EFTrackingSim/TrigHTTHough/src/HTTHough1DShiftTool.cxx:470:27: warning: unused function 'to_string' [-Wunused-function]
static inline std::string to_string(const std::vector<size_t> &v)
                          ^
/build/atnight/localbuilds/nightlies/Athena/master/athena/Trigger/EFTracking/EFTrackingSim/TrigHTTHough/src/HTTHough1DShiftTool.cxx:646:19: warning: unused function 'layersHit' [-Wunused-function]
static inline int layersHit(HTTRoad& r) {

ping @ssnyder @fwinkl @sroe to avoid work duplication.

Edited by Christos Anastopoulos

Merge request reports