Add TRT and Pixel PID information when creating track particles (sweep from master).
manual sweep of MR !53027 (merged) from master to 22.0.
Add TRT and Pixel PID information directly to track particles rather than first adding the information to the track summary, For statistically combined muon track particles compute pixel PID, but only copy TRT PID information over from the input track particles (original behaviour).
For the code path not starting from tracks only the default Pixel and TRT PID values are set (tracks are needed to run the PID).
Merge request reports
Activity
added Run2-DataReco-output-changed Run2-MCReco-output-changed labels
Will change for TRT standalone based GSFTrackParticles the value of eProbabilityNN (see MR !53027 (merged) for further discussion)
yes I wanted to aks this ... I guess we need this label from a developer side after Monday 23?
For this propability (TRT NN) I even do not know 100% anymore ,as an example look also slide 3 from PC [https://indico.cern.ch/event/1160792/contributions/4874944/attachments/2444832/4189177/pc-intro16may2022.pdf]
So there might be something more on this "saga" for the HLT at least (dropping it completely there ...).
So @goetz I would really not bother too much on this as there are discussion ongoing to understand ... Run-2 was not used at all. And now there is doubt even for the Run-3 version in places (HLT).
I guess if PC mentions it , something more is expected to go into the release here somehow so not sure how "violating" prob NN changes are ...
Edited by Christos AnastopoulosSee slide 8 in today's ATLAS Weekly:
https://indico.cern.ch/event/1160270/contributions/4877937/attachments/2445593/4190514/220517_ATLASWeekly.pdfOK I'll leave it up to PROC if they actually want to merge this just for the technical validation of the procedure. As discussed, these changes will be anyway brought into 22.0 by the rebase next week and we generally don't accept MRs into 22.0 this week except for testing the infrastructure. Either way is fine from the Trigger side, so approving.
CI Result SUCCESS (hash 92bd39ef)Athena DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 52321]added review-approved label and removed review-pending-level-1 label
added sweep:from master label
I manually added the sweep:from master label since it's a manual sweep. This should prevent the automatic sweep back to master (once everything is set up correctly).
Edited by Rafal Bielskiadded review-approved-point1 label
added analysis-review-approved label and removed analysis-review-required label
Marking this as analysis-review-approved since it is branch 22.0. I think that isn't even meant to get analysis labels.