Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 174
    • Merge requests 174
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !53350

Track overlay implementation part 3

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged William Axel Leight requested to merge wleight/athena:trackOverlay_OverlayCopy into master May 17, 2022
  • Overview 62
  • Commits 6
  • Pipelines 4
  • Changes 31

Most of these changes are for the switch to using OverlayCopyAlgs to copy the containers created by the track overlay through the overlay digitization step. A new alg is added for each type of container. Use of the algs is implemented for both legacy and CA configuration.

This requires modifying the changes I previously made to the ID ROT converters to handle the fact that the PRD container names are hardcoded in the trans-to-pers conversion. Luckily, this can be simplified, as a different name is now only needed at the end of the overlay step. However, to make sure that the converter knows it is in this step, I have loaded the EventCnvTool into the overlay step (since the converters read this already, and I didn't want to make too many changes to them).

The remaining changes are to implement track overlay in the overlay step for the CA configuration. If track overlay is on, then only the hard-scatter digitization is run, and not the rest of the ID overlay.

Edited May 18, 2022 by William Axel Leight
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: trackOverlay_OverlayCopy