flatten localToGlobal in all cases and also for opt builds

We were flattening in one case (perigeeSurface) but in my understanding only for debug builds (special trick from @ssnyder compiling the code with opt even in debug build and using attribute flatten).

The issue is "opt" does not "flatten" (actually the aim of the flatten is to inline the Eigen code)
either with gcc11...


Before this MR in opt

Screenshot_2022-05-17_at_19.08.30 Screenshot_2022-05-17_at_19.09.20 Screenshot_2022-05-17_at_19.09.11

After the MR in opt

Screenshot_2022-05-17_at_19.08.43 Screenshot_2022-05-17_at_19.09.33 Screenshot_2022-05-17_at_19.08.52

ping @ssnyder so as to take a look

For completeness I noticed this here first so have an example handy

So this "inlining" is something that clang does (also previous versions) but gcc stopped doing...
"This" -> is inline certain 5x5 matrix operations it seems .

Edited by Christos Anastopoulos

Merge request reports