Skip to content

fix AFP pixel numbering and particle propagation

Petr Balek requested to merge pbalek/athena:afp-fix-pixel-numbers into master

AFP pixel numbers should be from 0-79 and 0-335, as expected in AFP_PileUpTool. Here, we make pixels with numbers 1-80 and 1-336 if particle crosses pixel borders such that Y index increases/decreases.

Also fixing several bugs in particle propagation - position was updated only for one coordinate and in rare occasions it could be set totally off.

Finally, removes #defines and replaces them with static constexpr.

I'm not sure if violation of frozen tier-0 policy applies here. The output does change but this code isn't used for any data reconstruction...

Tagging @ladamczy

Closes AFPSOFT-139

Edited by Petr Balek

Merge request reports