TrkExtrapolator - Add protecton to prevent FPE happening in MuPatTrackBuilder
Closes ATLASRECTS-7104
Merge request reports
Activity
This merge request affects 1 package:
- Tracking/TrkExtrapolation/TrkExTools
This merge request affects 1 file:
- Tracking/TrkExtrapolation/TrkExTools/src/Extrapolator.cxx
Adding @amorley as watcher
added 22.0 Tracking review-pending-level-1 labels
thanks for this fix! can this numerical change propagate to any variable stored in AOD/ESD? if so I'd add the frozen-tier0-violating label for reference.
- Resolved by Peter Berta
added frozen-tier0-violating label
CI Result SUCCESS (hash 23931004) Athena DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 54649] added review-approved label and removed review-pending-level-1 label
added review-approved-point1 label
Hi,
Just making sure https://godbolt.org/z/1T81fj3E6
type │ epsilon() │ min() float │ 1.19209e-07 │ 1.17549e-38 double │ 2.22045e-16 │ 2.22507e-308
In many other cases to avoid division with 0 we went with the float min (1e-38) or the double epsilon if I recall we had a couple of similar cases . I am sure we had a case we did that but for a double with the float min but not the epsilon. Are you sure you want to go with with e-07 here?
Edited by Christos AnastopoulosThe question though is if it can matter for FT0, or there is a reasoning in the reciprocal. As naively here you want the smaller number possible not giving div by 0 or so no?
Edited by Christos Anastopoulosadded review-approved-tier0 label
mentioned in commit 5b97758e