Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 132
    • Merge requests 132
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !54575

MuonCondAlg - Add NSW conditions test as ctest & misc clean-up

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Johannes Junggeburth requested to merge jojungge/athena:NSW_ctest into 22.0 Jun 27, 2022
  • Overview 37
  • Commits 11
  • Changes 29

Hello everybody,

this MR is another step to chasing the irreproducibility reported in ATLASRECTS-7107.

  • The NswCondAlgTest.py joboptions have been ported to ComponentAccumulator in order to include them in the ctests of the package. Since there was the hypothesis that maybe the calibration constants themselves might be irreproducible, a test script has been added which executes 5 times in a row the test and ensures that the dump of the constants remains the same. The test has been locally executed 100 times with no hint of irreproducibility. So this one is fine

  • Add NSWPassivationAlg ctest. Twice execution of the NSWPassivationAlg to ensure that the readout of the passivation constants remain the same.

  • The MdtCablingTest is moved to the MuonCondTest package. An extra test on the Run 3 geometry has been added (cf. ATLASRECTS-7016)

  • Improve the data navigation in NswCalibDbTimeChargeData & NswCalibDbThresholdData. So not call the map find operation multiple times in a row. Ensure that the threshold is set to 0 if no key could be found in the database.

  • Remove various deprecated testing algorithms.

Tagging: @cheidegg, @pscholer

Edited Jun 29, 2022 by Johannes Junggeburth
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: NSW_ctest