Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 138
    • Merge requests 138
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !54607

SelectionHelpers: thread-checker fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Frank Winklmeier requested to merge fwinkl/athena:selhelpers into master Jun 28, 2022
  • Overview 14
  • Commits 1
  • Pipelines 2
  • Changes 9

Use asg::AsgMessagingForward instead of raw MsgStream pointer for messaging. The latter is not guaranteed to be thread-safe as in the general case, the MsgStream of the "owner" is implemented as thread-local.

Also remove the usage of MsgStream entirely from SelectionReadHandle (which itself seems entirely unused).

Enable thread-checker.

Edited Jun 28, 2022 by Frank Winklmeier
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: selhelpers