Skip to content

NSWCalibTool - Ensure that the PDO/TDO values are set to zero if calib fails

Johannes Junggeburth requested to merge jojungge/athena:calib_tool_default into 22.0

Hello everybody,

@pscholer and I checked the outputs from the last couple TCT q445 output files. We found that the serial tests have binary identical micromega and sTGC PRDS while the test from July 2nd shows huge differences in the micromegas - Different numbers of strips in each cluster - and the one from July 3rd has tiny differences in the sSTGCs. Now I am looking for places suspicious places in the code explaining them. One potential issue might be that it's never checked that the calibration is successful. Eventhough, the tool interface pipes the variables to calibrate via its arguments and the success is indicated by the return argument. IF the variable piped is declared but not initialized it could explain these irreproducibilities.

In the MR, it is ensured that the variables are always set by the tool to something.

Targets ATLASRECTS-7101/ATLASRECTS-7107

Tagging: @chchau

Edited by Johannes Junggeburth

Merge request reports